chore: remove flakybot configuration (long retired) #4145
Conversation
product-auto-label
bot
added
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @briandorsey, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request finalizes the removal of the flakybot configuration from the repository. It systematically cleans up all related files and references, ensuring that the project no longer relies on or includes artifacts from this retired system. This is a maintenance task aimed at streamlining the repository's configuration.
Highlights
- Flakybot Deprecation: This pull request completes the deprecation of the
flakybotconfiguration from the repository, addressing the internal tracking issue b/434770885. - Configuration Cleanup: The
flakybot.yamlfile has been entirely removed, and its references have been purged from.github/config/nodejs-dev.jsoncand.github/config/nodejs.jsonc.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly removes the configuration for the retired flakybot. The changes include deleting the .github/flakybot.yaml file and removing its references from the nodejs-dev.jsonc and nodejs.jsonc configuration files. This improves repository maintainability by removing obsolete code. The changes are straightforward and have been implemented correctly.
|
Since these changes affected workflows, some product specific tests ran (and failed). After spot checking logs and because these changes only removed workflow steps, I don't believe any of these test failures are caused by this PR. |
|
The failing tests on this repo are pending migration to a new CI system (custard). They are failing for unrelated reasons to this change. |
Follow up to #4145, removing Custard config references to flakybot.yaml, which is no longer in the repository.
Follow up to #4145, removing Custard config references to flakybot.yaml, which is no longer in the repository.
2 participants
Description
Addresses b/434770885 (Complete flakybot deprecation) for this repo.
Checklist